Updated nocodes logic and dart version #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpertsyanKM
reviewed
Nov 11, 2025
| Constants.kProjectKey: config.projectKey, | ||
| Constants.kVersion: QonversionInternal.sdkVersion, | ||
| Constants.kSource: Constants.sdkSource, | ||
| if (config.proxyUrl != null) Constants.kProxyUrl: config.proxyUrl, |
Contributor
There was a problem hiding this comment.
if we add without the null-check, will it break up?
Contributor
Author
There was a problem hiding this comment.
It's better to check to avoid unnecessary behavior
SpertsyanKM
reviewed
Nov 21, 2025
| _channel.invokeMethod(Constants.mInitializeNoCodes, args); | ||
| // Initialize is fire-and-forget, errors will be handled in subsequent calls | ||
| _channel.invokeMethod(Constants.mInitializeNoCodes, args).catchError((error) { | ||
| // Silently ignore initialization errors |
Contributor
There was a problem hiding this comment.
Let's log them at least
SpertsyanKM
reviewed
Nov 21, 2025
| throw _convertPlatformException(e); | ||
| final result = QMapper.userFromJson(rawResult); | ||
| if (result == null) { | ||
| throw new Exception("User deserialization failed"); |
Contributor
There was a problem hiding this comment.
Here and below lets replace all Exceptions with Qonversion ones
SpertsyanKM
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.