Update build-ubuntu-rootfs.sh #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-khuzuri
requested review from
bjordiscollaku,
simonbeaudoin0935,
sjakki88 and
vishwasudupa
as code owners
vishwasudupa
approved these changes
Sep 15, 2025
There was a problem hiding this comment.
ready to merge, will be merged post
https://github.com/qualcomm-linux/kernel-config/pull/68/files
potential bug possible, target name of hamoa not mentioned
menuentry "Ubuntu ${CODENAME} IoT for X Elite CRD" --id ${CODENAME}_crd
, needs to be cleaned up, based on @bjordiscollaku inputs
Device tree parameter in menu entry is not required for QLI targets, since its already fulfilled with dtb.bin. Added support for separate menu entry to accomodate the QLI targets. Signed-off-by: quic-khuzuri <khuzuri@qti.qualcomm.com>
quic-khuzuri
force-pushed
the
latest
branch
from
9e6f692 to
1ca2384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for menu entry to accomodate QLI targets