Add zstd archive to tagged releases #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smuppand
reviewed
Jul 2, 2025
|
|
||
| on: | ||
| push: | ||
| tags: |
There was a problem hiding this comment.
It should either track all tags or specific patterns?
smuppand
reviewed
Jul 2, 2025
.github/workflows/zstd.yml
Outdated
| - name: Create zstd archive without prefix | ||
| run: | | ||
| cd .. | ||
| tar --exclude='./qcom-linux-testkit/.git' -I zstd -cf ${{ steps.version.outputs.tag_name }}.tar.zst qcom-linux-testkit |
There was a problem hiding this comment.
Avoid archiving the working directory, instead use a clean git archive.
-I zstd its better to control compression level? but if we adopt git archive, this becomes simpler.
|
@smuppand what is the tag format you'll be using? |
We can follow SemVer tags. Git tag: v1.1.0 Archive filename: qcom-testkit-v1.1.0.zst |
zstd archive helps with running tests on space constrained systems. It's already supported in LAVA and tuxlava (template renderer). This patch will make it possible to use qcom-linux-testkit in tuxlava. Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
|
@smuppand I implemented your suggestions. I didn't test this. Please review and make changes if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zstd archive helps with running tests on space constrained systems. It's already supported in LAVA and tuxlava (template renderer). This patch will make it possible to use qcom-linux-testkit in tuxlava.