Fix partition tables #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lumag
commented
Jun 27, 2025
lumag
commented
- Rename subdirs to follow machine names
- Pick up a patch from meta-qcom to fix partition table for QCS9100 RIDE-SX
- Pick up QCS8300 RIDE-SX partition table from meta-qcom
Partition table is defined for a particular device rather than an SoC family. Rename qcm6490 to qcs6490-rb3gen2 and qcs9100 to qcs9100-ride-sx in order to follow actual device names. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
There is no partition type argument, should be type-guid instead. Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Copy partition scheme from the meta-qcom layer. The only difference to the QCS9100 RIDE SX is the rootfs size. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
lumag
requested review from
ndechesne,
sbanerjee-quic and
vkraleti
as code owners
ndechesne
approved these changes
Jun 27, 2025
|
I am ok with this change, but it did break qcom-deb-images which is building against qcom-ptool and probably at least one downstream build: should we consider tagging qcom-ptool releases? |
|
Please use commit IDs. Partition tables might change following the QLI releases, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.