Fix GPT file names to use .bin extension in gen_contents.py #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct the filenames for GPT partitions in the generated contents.xml to use `.bin` instead of `.xml` to match with the actual content being generated at build time and to ensure the correct files are flashed. Signed-off-by: Viswanath Kraleti <viswanath.kraleti@oss.qualcomm.com>
vkraleti
requested review from
lumag,
ndechesne and
sbanerjee-quic
as code owners
vkraleti
requested review from
lool and
ricardosalveti
and removed request for
lumag,
ndechesne and
sbanerjee-quic
This was referenced Sep 24, 2025
lool
reviewed
Sep 24, 2025
lool
approved these changes
Sep 24, 2025
koenkooi
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the filenames for GPT partitions in the generated contents.xml to use
.bininstead of.xmlto match with the actual content being generated at build time and to ensure the correct files are flashed.