Added Simon's Algorithm Example #1908

Lucaman99 · 2019-08-02T13:08:40Z

This pull request adds an implementation of Simon's Algorithm to the examples folder. There is still a bug that occasionally occurs when the code is run, where the secret function is not constructed properly and the simulation fails. I'm looking into the cause of this issue right now, but I thought I would just submit a pull request now, so the code-review process can start as soon as possible.

googlebot · 2019-08-02T13:08:42Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

vtomole · 2019-08-02T13:54:09Z

@Lucaman99 There is no code in this pull request.

Lucaman99 · 2019-08-02T13:58:39Z

Sorry about that, I was editing the wrong file on my local branch

vtomole

Good start! Move everything into a function and add

if __name__ == '__main__':
    main()

at the end of the file. Also, make sure all the builds pass: https://github.com/quantumlib/Cirq/pull/1908/checks?check_run_id=184024079

vtomole · 2019-08-11T17:04:27Z

examples/simon.py

@@ -0,0 +1,339 @@
+'''


Suggested change

'''

'''Demonstrates Simon's algorithm.

vtomole · 2019-08-11T17:04:48Z

examples/simon.py

@@ -0,0 +1,339 @@
+'''
+---------------------------------
+SIMONS'S ALGORITHM - OVERVIEW


Suggested change

SIMONS'S ALGORITHM - OVERVIEW

vtomole · 2019-08-11T17:07:22Z

examples/simon.py

+SIMONS'S ALGORITHM - OVERVIEW
+---------------------------------
+Simon's Algorithm solves the problem of finding a particular value of s when some function f:{0, 1}^n --> {0, 1}^n
+is inputted into the program that follows this rule: "f(x) = f(y) if and only if x (+) y is in the set {0^n, s}"


Suggested change

is inputted into the program that follows this rule: "f(x) = f(y) if and only if x (+) y is in the set {0^n, s}"

is inputted into the program that follows this rule: "f(x) = f(y) if and only if x xor y is in the set {0^n, s}"

vtomole · 2019-08-11T17:09:08Z

examples/simon.py

+---------------------------------
+Simon's Algorithm solves the problem of finding a particular value of s when some function f:{0, 1}^n --> {0, 1}^n
+is inputted into the program that follows this rule: "f(x) = f(y) if and only if x (+) y is in the set {0^n, s}"
+---------------------------------


Delete this STEPS section and replace it with a reference to Simon's Paper: https://epubs.siam.org/doi/10.1137/S0097539796298637

vtomole · 2019-08-11T17:10:22Z

examples/simon.py

+
+# Qubit preparation
+
+number_qubits = #Number of qubits


What's this variable set to?

vtomole · 2019-08-11T17:14:22Z

examples/simon.py

+
+                    last_work = copy.deepcopy(list(element))
+
+                    #Check for linear independence


Suggested change

#Check for linear independence

# Check for linear independence

vtomole · 2019-08-11T17:17:48Z

examples/simon.py

+    simulator = cirq.Simulator()
+    result = simulator.run(c, repetitions=number_qubits-1)
+    final = result.histogram(key='y')
+    print("Secret String: "+str(s))


Use format() when printing.

Or f strings f"like this {variable_name}"

vtomole · 2019-08-11T17:27:06Z

examples/simon.py

+    return last_work
+
+def construct_solve(matrix_out):
+


Add a comment explaining what this procedure does.

vtomole · 2019-08-11T17:28:52Z

examples/simon.py

+processing2 = ''.join(str(x) for x in try_2)
+
+the_last = 0
+if (secret_function[1][secret_function[0].index(0)] == secret_function[1][secret_function[0].index(int(processing1, 2))] and secret_function[1][secret_function[0].index(0)] == secret_function[1][secret_function[0].index(int(processing2, 2))]):


This statement is too long. Create an appropriately named and commented procedure that does this.

vtomole · 2019-08-11T17:29:39Z

examples/simon.py

+r = run[3]
+
+def shuffle_op(matrix, point):
+


Add comments in what this does.

vtomole · 2019-09-25T02:23:22Z

@Lucaman99 You don't have to make the change yourself for one liners if they are suggested. Simply click "commit suggestion".

Strilanc · 2019-09-25T02:46:42Z

examples/simon.py

+
+# Qubit preparation
+
+number_qubits = #Number of qubits


Redundant comment. Don't repeat what the code says word for word.

Strilanc

I suspect that with some effort we can get these three hundred lines down to fifty much clearer lines. But there's a lot of refactoring between here and there. I've left a lot of individual comments to get you started.

Strilanc · 2019-09-25T02:47:31Z

examples/simon.py

+    #Hard-code oracle on a case-by-case basis
+
+
+    for o in range(0, len(secret_function[0])):


Avoid o since it looks like zero.

Strilanc · 2019-09-25T02:49:56Z

examples/simon.py

+
+    for o in range(0, len(secret_function[0])):
+        counter = 0
+        for j in list(str(format(secret_function[0][o], "0"+str(number_qubits)+"b"))):


This strikes me as "stringly typed programming", where you are unnecessarily encoding the logic into string operations.

Strilanc · 2019-09-25T02:51:02Z

examples/simon.py

+    s = domain[random.randint(0, len(domain)-1)]
+
+    #Create the "secret function"
+    for g in range(0, int((2**number_qubits)/2)):


Extract this entire section about making the secret function into a method called create_secret_function

Strilanc · 2019-09-25T02:52:04Z

examples/simon.py

+    co_domain = []
+    fixed = []
+
+    for k in range(0, 2**number_qubits):


domain = list(range(2**number_qubits)) selector = list(domain) fixed = list(domain) co_domain = [False] * 2**number_qubits

Strilanc · 2019-09-25T02:53:18Z

examples/simon.py

+
+    secret_function = [fixed, co_domain]
+
+    oracle = make_oracle(ancilla, secret_function, first_qubits, second_qubits, s, the_activator)


Use better names than first_qubits and second_qubits. Refer to their role in the algorithm.

Rename s to a word.

Drop the the in the_activator.

Strilanc · 2019-09-25T03:08:15Z

examples/simon.py

+            for ik in range (0, len(hol)):
+                if (hol[ik] == hol[ij] and ik != ij):
+                    ha = False
+        if (ha == True and calc == [0 for p in range(0, len(calc))]):


if ha and calc == [0] * len(calc):

Strilanc · 2019-09-25T03:08:39Z

examples/simon.py

+    for i in range(1, len(matrix)+1):
+      for c in list(itertools.combinations([y[0:len(matrix)+1] for y in matrix], i)):
+        hol = []
+        for b in c:


hol = list(c)

Strilanc · 2019-09-25T03:08:56Z

examples/simon.py

+
+    for i in range(0, len(matrix)):
+        for j in range(i+1, len(matrix)):
+            if (matrix[i][i] != 0):


Move this condition into the outer loop

Strilanc · 2019-09-25T03:12:40Z

examples/simon.py

+    for i in range(0, len(matrix)):
+        for j in range(i+1, len(matrix)):
+            if (matrix[i][i] != 0):
+                x = -1*matrix[j][i]/matrix[i][i]


I think this block is just matrix[j] -= matrix[i] * int(matrix[j][i] / matrix[i][i]), assuming matrix is a numpy array.

Strilanc · 2019-09-25T03:13:21Z

examples/simon.py

+
+        for j in range(0, len(work[0])-1):
+            temporary = []
+            for g in range(0, len(work)):


temporary = [e for e in work if e[j] == 1]

Strilanc · 2019-09-25T03:19:23Z

I think if you add all the relevant email addresses to your github account it might resolve the issue. You do need to sign the CLA from each of them.

For now I wouldn't worry about the CLA; there's lots of refactoring to do first.

Lucaman99 · 2019-09-25T03:30:41Z

@Strilanc Yeah, we're talking about the CLA in relation to my other pull request #1934, which seems to be ready to be merged.

vtomole · 2019-09-25T03:34:35Z

@Lucaman99 Far from ready. I just like seeing green check-marks on pull requests :D. I want to leave the reviews in rounds so it's easy to respond in chunks.

vtomole · 2019-12-11T17:24:04Z

Hey @Lucaman99, how's this going?

vtomole · 2020-02-18T23:05:17Z

Closing as there is another Simon's Pull request open.

Simon's Algorithm

7e6f543

googlebot added the cla: no label Aug 2, 2019

Simon's Algorithm

9bbdb8e

vtomole requested changes Aug 11, 2019

View reviewed changes

Strilanc reviewed Sep 25, 2019

View reviewed changes

Strilanc requested changes Sep 25, 2019

View reviewed changes

vtomole mentioned this pull request Dec 16, 2019

Add Simon's algorithm example #1780

Closed

vtomole closed this Feb 18, 2020

	is inputted into the program that follows this rule: "f(x) = f(y) if and only if x (+) y is in the set {0^n, s}"
	is inputted into the program that follows this rule: "f(x) = f(y) if and only if x xor y is in the set {0^n, s}"


		last_work = copy.deepcopy(list(element))

		#Check for linear independence

	#Check for linear independence
	# Check for linear independence

		#Hard-code oracle on a case-by-case basis


		for o in range(0, len(secret_function[0])):


		secret_function = [fixed, co_domain]

		oracle = make_oracle(ancilla, secret_function, first_qubits, second_qubits, s, the_activator)

Added Simon's Algorithm Example #1908

Added Simon's Algorithm Example #1908

Uh oh!

Conversation

Lucaman99 commented Aug 2, 2019

Uh oh!

googlebot commented Aug 2, 2019

Uh oh!

vtomole commented Aug 2, 2019

Uh oh!

Lucaman99 commented Aug 2, 2019

Uh oh!

vtomole left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vtomole commented Sep 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Strilanc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Strilanc commented Sep 25, 2019

Uh oh!

Lucaman99 commented Sep 25, 2019

Uh oh!

vtomole commented Sep 25, 2019

Uh oh!

vtomole commented Dec 11, 2019

Uh oh!

vtomole commented Feb 18, 2020

Uh oh!

Uh oh!

vtomole left a comment •

edited

Loading

vtomole commented Sep 25, 2019 •

edited

Loading