Created Quantum Walks Tutorial #2657

Lucaman99 · 2019-12-17T05:00:22Z

Sorry for opening another PR, but the CLA in the other request simply won't go through. This takes into account a lot of the changes requested in #1934.

googlebot · 2019-12-17T05:00:32Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Lucaman99 · 2019-12-17T14:40:06Z

Also @Strilanc, I made all of the requested changes to built-in Cirq functions, however, wasn't able to find documentation for the Cirq ArithmeticOperations class. As a result, this is the one change I haven't made yet, is this a fairly new feature?

vtomole · 2019-12-18T19:56:30Z

@Lucaman99 Sign the CLA. Otherwise we could override; which means the old pull request is fine to use for these new changes.

Lucaman99 · 2019-12-18T19:58:58Z

I have, but it's saying that "co-contributors" to this commit haven't signed it, which is likely due to me accidentally using a different email when I made some of the commits a couple months back

Lucaman99 · 2019-12-18T19:59:11Z

"We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors."

Lucaman99 · 2019-12-18T19:59:36Z

@googlebot I fixed it.

vtomole · 2020-01-08T19:57:15Z

@Lucaman99 The reason we have this new pull request is to get past this CLA issue. Squash these commits so this pull request doesn't contain the non-CLA.

Lucaman99 · 2020-01-16T18:58:34Z

Squash all the commits previous to the most recent one?

vtomole · 2020-01-16T20:07:54Z

@Lucaman99 Yes, then change the commit email to the primary one on your GitHub account (https://stackoverflow.com/a/3042512/5716192).

When you Cirq$ git config --list, is the user.email the primary one in your Github account?

Lucaman99 · 2020-03-01T19:02:00Z

Hi @vtomole! Just wanted to ping you in case you hadn't seen this yet, I made the requested changes last week. Let me know when you get the chance to take a look! 🙂

vtomole · 2020-03-02T14:50:43Z

examples/notebook_tutorials/new_test.py

@@ -0,0 +1,57 @@
+# Licensed under the Apache License, Version 2.0 (the "License");


You missed removing this file: . See #2657 (comment)

Lucaman99 · 2020-03-02T17:28:00Z

@vtomole Sorry about that, I just deleted it

vtomole

LGTM. Rename notebook_tutorials to notebooks and we'll merge it in.

Lucaman99 · 2020-03-09T00:56:45Z

Done!

vtomole · 2020-03-09T16:41:23Z

Hey @dstrain115, You'll need to manually add the cla for us to merge this.

googlebot · 2020-03-09T16:51:03Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

dstrain115 · 2020-03-09T16:52:18Z

Added the CLA manually. Hopefully that fixes things.

You may want to make sure that all your environments are set up with the same git author so that this doesn't complain in the future.

googlebot · 2020-03-09T17:06:49Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

vtomole · 2020-03-09T17:08:49Z

examples/notebooks/nqubittoff.ipynb

@@ -0,0 +1,123 @@
+{


Remove this file

Lucaman99 · 2020-03-09T18:06:05Z

Ok, done

vtomole · 2020-03-09T18:15:31Z

@Lucaman99 Looks like my merge voided the cla. I think this is what we should do: copy these files into a new branch and commit them with the email address with which you signed the cla and open a new pull request.

Lucaman99 · 2020-03-09T18:17:17Z

Sounds good, I'll do that right now

Jack Ceroni and others added 18 commits August 12, 2019 16:22

Added QRW Tutorial Notebook

7344502

QRW

c9fe7cd

QRW2

0263817

QRW3

7f24b29

Update random_walk_tutorial.ipynb

086317a

QRW4

db46fc8

Update random_walk_tutorial.ipynb

e4c36ac

Revert

38c642b

Hm

298b9f1

Final QRW

3d475a2

QRW Final

332675c

Merge branch 'master' into cirq_ex_2

32c6d83

QRW Next

7070761

QRW Next 2

00e8d11

QRW Next 3

8d4d1b6

QRW Next 4

ec54c8f

Added Test

5d2261b

Changes

0985180

googlebot added the cla: no label Dec 17, 2019

Lucaman99 mentioned this pull request Dec 17, 2019

Add Quantum Random Walk Tutorial Notebook #1934

Closed

vtomole requested a review from Strilanc December 18, 2019 20:01

Lucaman99 added 3 commits February 23, 2020 21:43

Fixed

080020f

Fixed2

e5efe66

Fixed3

0cf81da

vtomole reviewed Mar 2, 2020

View reviewed changes

New

e4089c2

vtomole approved these changes Mar 6, 2020

View reviewed changes

Final

76d8ff0

dstrain115 added cla: yes Makes googlebot stop complaining. and removed cla: no labels Mar 9, 2020

Merge branch 'master' into cirq_tutorial

c9f086d

googlebot added cla: no and removed cla: yes Makes googlebot stop complaining. labels Mar 9, 2020

vtomole requested changes Mar 9, 2020

View reviewed changes

examples/notebooks/nqubittoff.ipynb Outdated

@@ -0,0 +1,123 @@

{

Copy link

Collaborator

vtomole Mar 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file

Lucaman99 added 6 commits March 9, 2020 14:03

Delete nqubittoff.ipynb

0057872

Delete random_walk_tutorial.ipynb

1c3e789

Delete circ2.png

371bca5

Delete cycle.png

39ea413

Delete circ2.png

7fce96b

Delete cycle.png

7c2ed7b

Lucaman99 closed this Mar 9, 2020

		@@ -0,0 +1,57 @@
		# Licensed under the Apache License, Version 2.0 (the "License");

Created Quantum Walks Tutorial #2657

Created Quantum Walks Tutorial #2657

Uh oh!

Conversation

Lucaman99 commented Dec 17, 2019

Uh oh!

googlebot commented Dec 17, 2019

Uh oh!

Lucaman99 commented Dec 17, 2019

Uh oh!

vtomole commented Dec 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Lucaman99 commented Dec 18, 2019

Uh oh!

Lucaman99 commented Dec 18, 2019

Uh oh!

Lucaman99 commented Dec 18, 2019

Uh oh!

vtomole commented Jan 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Lucaman99 commented Jan 16, 2020

Uh oh!

vtomole commented Jan 16, 2020

Uh oh!

Lucaman99 commented Mar 1, 2020

Uh oh!

vtomole Mar 2, 2020

Choose a reason for hiding this comment

Uh oh!

Lucaman99 commented Mar 2, 2020

Uh oh!

vtomole left a comment

Choose a reason for hiding this comment

Uh oh!

Lucaman99 commented Mar 9, 2020

Uh oh!

vtomole commented Mar 9, 2020

Uh oh!

googlebot commented Mar 9, 2020

Uh oh!

dstrain115 commented Mar 9, 2020

Uh oh!

googlebot commented Mar 9, 2020

Uh oh!

vtomole Mar 9, 2020

Choose a reason for hiding this comment

Uh oh!

Lucaman99 commented Mar 9, 2020

Uh oh!

vtomole commented Mar 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Lucaman99 commented Mar 9, 2020

Uh oh!

Uh oh!

vtomole commented Dec 18, 2019 •

edited

Loading

vtomole commented Jan 8, 2020 •

edited

Loading

vtomole commented Mar 9, 2020 •

edited

Loading