Fix command-line engine start up guide #3304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dstrain115
commented
Sep 9, 2020
dstrain115
commented
- Fix list bulleting
- Fix printing URL to use job_id and program_id
- Fix list bulleting - Fix printing URL to use job_id and program_id
viathor
approved these changes
Sep 9, 2020
docs/tutorials/google/start.ipynb
Outdated
| " \"programs{}?mods=quantum_ng2&project={}\".format(\n", | ||
| " job.job_resource_name.split('/programs')[1], project_id))\n", | ||
| " f\"programs/{job.program_id}/jobs/{job.job_id}\"\n", | ||
| " f\"/overview?project={project_id}\")\n", |
There was a problem hiding this comment.
I think we should put the URL-construction into an easily discoverable function somewhere. WDYT?
(Out of scope for this PR.)
There was a problem hiding this comment.
Yeah, that's a good idea. I'll add it to my TODOs.
docs/tutorials/google/start.ipynb
Outdated
| " print(\"Scheduled. View the job at: https://console.cloud.google.com/quantum/\"\n", | ||
| " \"programs{}?mods=quantum_ng2&project={}\".format(\n", | ||
| " job.job_resource_name.split('/programs')[1], project_id))\n", | ||
| " f\"programs/{job.program_id}/jobs/{job.job_id}\"\n", |
There was a problem hiding this comment.
nit: shouldn't you keep the old indentation?
There was a problem hiding this comment.
Isn't this basically the same indentation? I just changed it to a f string instead of the format. Or do you think I should indent so the f is under the quotes?
There was a problem hiding this comment.
I think under the quotes. The number of spaces should stay fixed :-)
balopat
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.