Skip to content

Add methods for converting dict to product or zip sweep and deprecate implicit cartesian product #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 18, 2020
Merged

Add methods for converting dict to product or zip sweep and deprecate implicit cartesian product #3333

merged 5 commits into from
Sep 18, 2020

Conversation

kevinsung
Copy link
Collaborator

Fixes #2698 .
Fixes #3018 .

@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Sep 17, 2020
@kevinsung kevinsung mentioned this pull request Sep 17, 2020
Closed
balopat
balopat approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nitpick.

@crystalzhaizhai please have a look as well

crystalzhaizhai
crystalzhaizhai approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@crystalzhaizhai crystalzhaizhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
quick question: why use cirq.TParamkey?

@kevinsung
Copy link
Collaborator Author

Parameter keys can be of type sympy.Basic in addition to string. We use TParamKey to represent the type of a parameter so we can define it in one place and also make the code more readable.

@kevinsung kevinsung added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Sep 18, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Sep 18, 2020
@CirqBot CirqBot merged commit 0105808 into quantumlib:master Sep 18, 2020
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Sep 18, 2020
@kevinsung kevinsung deleted the sweeps-3 branch September 19, 2020 02:10
@kevinsung kevinsung mentioned this pull request Sep 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Strilanc Strilanc Awaiting requested review from Strilanc

2 more reviewers

@balopat balopat balopat approved these changes

@crystalzhaizhai crystalzhaizhai crystalzhaizhai approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate implicit cartesian product behavior in to_sweeps. Expand SWEEP_LIKE to work for {'t': [0, 1, 3]}
5 participants
@kevinsung @balopat @crystalzhaizhai @googlebot @CirqBot