Fixes transform.ipynb and adds notebook testing #3497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balopat
force-pushed
the
fix_transform_notebook
branch
from
fdcb5aa to
9cefe90
Compare
balopat
changed the title
balopat
force-pushed
the
fix_transform_notebook
branch
from
87976f0 to
aa666ca
Compare
balopat
added
the
automerge
dstrain115
approved these changes
Nov 13, 2020
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. |
There was a problem hiding this comment.
I think we need more information about this, for people who follow in this footsteps and try to modify / augment this in the future.
Something akin to the PR description would be useful.
There was a problem hiding this comment.
Oh, I'll add that in then!!! Agreed on instructions - I think we should add something in the Development.MD as well!
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a missing import statement from transform.ipynb, also, adds notebook tests.
The notebook tests run in parallel and each of them in their own virtual env, ensuring that the
pip installstatements work well. This mirrors how the tests are run on devsite pipelines as well. Hopefully we can catch errors faster this way!Follow-up potentials:
I tested treebeard (#3504) github action, and finally settled on rolling my own driver with an executor. For executor I chose papermill as it simply worked just fine with xdist. Though probably I could use treebeard (?) - not sure what the benefit would be for individual notebook execution.
jupyter nbconvert --executedidn't seem to executepip installs? But I haven't gone too deep in that direction.Fixes #2711.