Fix EjectPhasedPaulis incorrectly treating X**0 as X**1 #4219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We setup pull request review rotation from the cirq-maintainers. It does it based on round robin. This reduces the notification noise at least for the cirq-maintainers team and also attempts to allocate PR reviews in a "fair" way. |
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
) Fixes quantumlib#4218 and adds a test for the previously failing case. The code treated the half-turns (exponent) value as whole-turns so both X**1 and X**0 were treated as whole X gates.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
) Fixes quantumlib#4218 and adds a test for the previously failing case. The code treated the half-turns (exponent) value as whole-turns so both X**1 and X**0 were treated as whole X gates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4218 and adds a test for the previously failing case.
The code treated the half-turns (exponent) value as whole-turns so both X1 and X0 were treated as whole X gates.