Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google colab tutorial - minor cleanup #5430

Merged
merged 4 commits into from
Jul 15, 2022

Conversation

verult
Copy link
Collaborator

@verult verult commented Jun 1, 2022

  • Import cirq and cirq_google up top
  • Update "Cirq documentation" link
  • "Authenticate and install Cirq" -> "Authenticate with Quantum Computing Service and install Cirq"

I linked to the full URL of the Cirq landing page. Let me know if there's a relative path that's more appropriate - I couldn't find the source location.

@MichaelBroughton
cc @dstrain115

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CirqBot CirqBot added the size: M 50< lines changed <250 label Jun 1, 2022
@verult verult marked this pull request as ready for review June 1, 2022 21:43
@verult verult requested review from wcourtney, a team, vtomole and cduck as code owners June 1, 2022 21:43
@MichaelBroughton
Copy link
Collaborator

These changes look good, I think we might need to keep the saved outputs for the engine components (otherwise the infra will try to run those cells). @dstrain115 .

@verult
Copy link
Collaborator Author

verult commented Jun 1, 2022

Ty for the review. For simplicity I reverted back all the output, since the only cell without engine references is Cirq installation.

Copy link
Collaborator

@dstrain115 dstrain115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the modifications, the changes are quite minor. LGTM.

@verult verult added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 15, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 15, 2022
@CirqBot CirqBot merged commit bf0a677 into quantumlib:master Jul 15, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 15, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
* Import cirq and cirq_google up top
* Update "Cirq documentation" link
- "Authenticate and install Cirq" -> "Authenticate with Quantum Computing Service and install Cirq"

I linked to the full URL of the Cirq landing page. Let me know if there's a relative path that's more appropriate - I couldn't find the source location.

@MichaelBroughton 
cc @dstrain115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants