Skip to content

Conversation

seunomonije
Copy link
Contributor

@seunomonije seunomonije commented Oct 1, 2025

Resolves #7654, sunsetting Webpack support and introducing the more modern Vite as the core bundler for typescript in Cirq.

Implementation notes:

  • Added a custom canvas polyfill in vitest.setup.ts, allowing for three.js to be tested without the browser environment. There have been discussions about this in Vite and external packages which could offer more context, but I opted to implement something custom considering that package deps have been pain point.
  • Testing and coverage matches 1:1 with old test criteria
  • We need to bump the node version up in the CI workflow to support more modern packages, bumped from v20 -> v22

@github-actions github-actions bot added the size: L 250< lines changed <1000 label Oct 1, 2025
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.38%. Comparing base (891e452) to head (665ea57).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7687   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files        1089     1089           
  Lines       97414    97414           
=======================================
  Hits        96812    96812           
  Misses        602      602           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@seunomonije seunomonije marked this pull request as ready for review October 1, 2025 18:03
@seunomonije seunomonije requested review from vtomole and a team as code owners October 1, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: L 250< lines changed <1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from Webpack to Vite for TS development
1 participant