Skip to content

Color mode corrections #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2024
Merged

Color mode corrections #1979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
039b986
fix table configurations and broken links on support page
insectengine May 15, 2024
04e76ea
fix tool tip mismatch with switcher
insectengine May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions _includes/support-help-band.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,20 @@
<h3>Getting Help from the Community</h3>
</div>
<div class="width-3-12 width-12-12-m help-block">
<img class="light-only" src="{{site.baseurl}}/assets/images/about/icon-documentation.svg">
<img class="dark-only" src="{{site.baseurl}}/assets/images/about/icon-documentation-dark.svg">
<img class="light-only" src="{{site.baseurl}}/assets/images/support/icon-documentation.svg">
<img class="dark-only" src="{{site.baseurl}}/assets/images/support/icon-documentation-dark.svg">
<h4>Documentation</h4>
<p>We have a lot of documentation. Be sure to check our <a href="{{site.baseurl}}/get-started/">Getting started page</a>, and all our <a href="{{site.baseurl}}/guides/">guides</a>. Also check out our <a href="{{site.baseurl}}/faq/">FAQ section</a> and <a href="https://www.youtube.com/playlist?list=PLsM3ZE5tGAVbMz1LJqc8L5LpnfxPPKloO">Quarkus Tips Playlist</a>.</p>
</div>
<div class="width-3-12 width-12-12-m help-block">
<img class="light-only" src="{{site.baseurl}}/assets/images/about/icon-stackoverflow.svg">
<img class="dark-only" src="{{site.baseurl}}/assets/images/about/icon-stackoverflow-dark.svg">
<img class="light-only" src="{{site.baseurl}}/assets/images/support/icon-stackoverflow.svg">
<img class="dark-only" src="{{site.baseurl}}/assets/images/support/icon-stackoverflow-dark.svg">
<h4>Stack Overflow</h4>
<p>Ask your questions on <a href="https://stackoverflow.com/questions/tagged/quarkus">Stack Overflow</a>. After the documentation, it’s probably the best place to look for answers. We actively monitor the <a href="https://stackoverflow.com/questions/tagged/quarkus">Quarkus tag</a>.</p>
</div>
<div class="width-3-12 width-12-12-m help-block">
<img class="light-only" src="{{site.baseurl}}/assets/images/about/icon-discussion.svg">
<img class="dark-only" src="{{site.baseurl}}/assets/images/about/icon-discussion-dark.svg">
<img class="light-only" src="{{site.baseurl}}/assets/images/support/icon-discussion.svg">
<img class="dark-only" src="{{site.baseurl}}/assets/images/support/icon-discussion-dark.svg">
<h4>Discussions and Collaboration</h4>
<p>Check out our <a href="https://github.com/quarkusio/quarkus/discussions">GitHub Discussions</a> collaboration area to interact with other Quarkus users and developers.</p>
</div>
Expand Down
4 changes: 3 additions & 1 deletion _sass/colormode.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ html.dark {
--title-background-color: #0e0e0e;
--breadcrumb-background-color: #0d1c2c;

--table-head-background-color: #333333;
--table-row-stripe: #e4edf7;

--card-outline: #555555;
--card-background-color: #0f0f0f;
--card-background-color-hover: #333333;
Expand All @@ -53,7 +56,6 @@ html.dark {

// Table overrides //
table.tableblock tbody tr:nth-child(even) { background-color: transparent !important; }
table.tableblock thead th { background-color: #333333 !important; }

// project footer //
.project-footer {
Expand Down
2 changes: 1 addition & 1 deletion _sass/core/global.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ table.tableblock {
}
tbody tr {
&:nth-child(even) {
background-color: $gray-0;
background-color: var(--table-row-stripe);
}
td p {
margin: 0;
Expand Down
26 changes: 15 additions & 11 deletions _sass/quarkus.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ input {
// table styles

table.tableblock {
border-collapse: collapse;
border-collapse: collapse !important;
max-width: 100%;
overflow-x: auto;
background-color: var(--main-background-color);
Expand All @@ -276,7 +276,7 @@ table.tableblock {
text-align: left;
padding: 1rem;
background-color: var(--table-head-background-color);
border: 1px solid var(--table-head-background-color);
border: 1px solid var(--sec-border-color);
> p,
> div,
> div > span {
Expand Down Expand Up @@ -366,16 +366,23 @@ table.configuration-reference-all-rows.tableblock > tbody {
table.configuration-reference.tableblock > tbody {

> tr > th {
color: $dark-blue;
background-color: var(--table-head-background-color);
border: 1px solid var(--sec-border-color);

a { color: $white;}
}

> tr {
background: transparent;

&:nth-child(even) {
background-color: var(--table-row-stripe);
}

> th:nth-child(1) { width: 70%; }
> th:nth-child(2) { width: 15%; p { color: $quarkus-blue; } }
> th:nth-child(3) { width: 15%; p { color: $quarkus-blue; } }
> th:nth-child(2) { width: 15%; p { color: $white; } }
> th:nth-child(3) { width: 15%; p { color: $white; } }
> td {
border: none;
border: 1px solid var(--sec-border-color);
}

> td:nth-child(2) p,
Expand All @@ -396,12 +403,9 @@ table.configuration-reference.tableblock > tbody {
> th:nth-child(3) { width: 0%; }
}
}

> tr.odd > td {
background-color: $light-blue !important;
}
}


/* this page has a white background so we put a lighter color */
body.guides-configuration-reference table.configuration-reference.tableblock tbody tr.odd td {
background-color: #eff5fb !important;
Expand Down
6 changes: 3 additions & 3 deletions assets/javascript/colormode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ function updateButton() {
const button = document.getElementById('theme-toggle');
const storedTheme = localStorage.getItem('color-theme') || 'system';
const themeTitles = {
'dark': 'Color scheme: dark; next: light',
'light': 'Color scheme: light; next: system preferences',
'system': 'Color scheme: system preferences; next: dark'
'dark': 'Color scheme: dark; next: system preferences',
'light': 'Color scheme: light; next: dark',
'system': 'Color scheme: system preferences; next: light'
};
button.setAttribute('aria-label', storedTheme);
button.setAttribute('title', themeTitles[storedTheme]);
Expand Down