setup for GitHub Enterprise

[ijlyttle]

fix #40

I took a first swing at documentation; I will be happy to revise as you wish.

Thanks!

[cscheid]

Thank you! Interesting, this turns out to be simpler than I thought.

@cderv this looks good to me, what do you think?

[cderv]

Thanks @ijlyttle !

Yes LGTM. We can't really test it but I suppose you did or can ?

[ijlyttle]

Hi @cderv - I have tested it on our instance, and it works for me™️.

Also, FWIW, because you are using the newer syntax for setting outputs, the runner version has to be at least 2.298.2.

I have a larger question about support for GitHub Enterprise, but the challenge is procedural, rather than technical. I don't think this thread is the right venue, so I'll use another venue.

[cderv]

because you are using the newer syntax for setting outputs, the runner version has to be at least 2.298.2.

We did the change because of this post and Github warning about deprecation. :)
So you mean our action won't work on GHE server that would run previous syntax, is that so ?

For now it would mean that you need to use a specific tag (probably @2.0.3) so that you don't get the change. We could also maintain a specific branch or specific tag if that helps.

We'll see what comes from the discussion in the other venue.

Thanks for the PR

[ijlyttle]

@cderv - no worries about the change, we upgraded the runner-version ourselves recently. It was just another thing for me to learn about 😅

I agree, using a specific branch or tag could be useful here.

[cderv]

I agree, using a specific branch or tag could be useful here.

We'll see if we find other specificity then.