typst logo padding shorthand #11074
Merged
typst logo padding shorthand #11074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordonwoodhull
force-pushed
the
feature/typst-logo-padding-shorthand
branch
from
b92abd3 to
70a5665
Compare
gordonwoodhull
force-pushed
the
feature/typst-logo-padding-shorthand
branch
from
70a5665 to
51877b2
Compare
in particular, typst logo wants to have padding-left, padding-top, etc
and individual control of each side's padding
gordonwoodhull
force-pushed
the
feature/typst-logo-padding-shorthand
branch
from
51877b2 to
b2fc83e
Compare
|
Also merging this once tests pass... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10982
In order to provide complete control over logo placement, the padding on each side should be independent.
The right way to do this is to implement the CSS
paddingshorthand along withpadding-left,padding-top, ...This required refactoring a lot more of
typst-css-property-processing.luato_quarto.modules.typst.cssAlso adds
_quarto.modules.typst.as_typst_dictionary_quarto.modules.typst.sortedPairs_quarto.utils.table.sortedPairs