HTML - fix block vs inline highlighting #12495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cderv
force-pushed
the
theme/css-highlight
branch
from
8aa0a5b to
d33489c
Compare
cderv
force-pushed
the
theme/css-highlight
branch
from
d33489c to
020fe26
Compare
Otherwise CSS specificity will not work as expected, and this is how it is done on Pandoc side which we are mimicking here.
add missing theme and order alphabetically
- Start by testing codeBlock vs InlineCode highlighting, using Keyword token as this is the common one in all theme
cderv
force-pushed
the
theme/css-highlight
branch
from
020fe26 to
cf416b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CSS rule for token keywords needs to be inserted after generic rules
Otherwise, CSS specificity will not work as expected. This is how it is done on the Pandoc side, which we are mimicking here.
fixes #11911
Later on for 1.8, we could rewrite all this part to closely match what Pandoc is doing in Haskell for our typescript processing creating SCSS rules instead of CSS. But this would require testing all themes I guess