Running tests on Windows

.github/workflows/actions/quarto-dev/action.yml

@@ -4,26 +4,32 @@ description: "Configures the image for Quarto Development"
 runs:
   using: "composite"
   steps:
-    - name: Set Path
+    - name: Configure Quarto (.sh)
+      if: runner.os != 'Windows'
       shell: bash
       run: |
-        echo "$HOME/bin" >> $GITHUB_PATH
+        # install with symlink in /usr/local/bin which in PATH on CI
+        ./configure.sh
 
-    - name: Configure Quarto
-      shell: bash
+    - name: Configure Quarto (.ps1)
+      if: runner.os == 'Windows'
+      shell: pwsh
       run: |
-        ./configure.sh
+        ./configure.cmd
+        "$(Get-ChildItem -Path ./package/dist/bin/quarto.cmd | %{ $_.FullName } | Split-Path)" >> $env:GITHUB_PATH
+
+    - shell: pwsh
+      if: runner.os == 'Windows'
+      run: $env:PATH -Split ";"
 
     - name: Basic dev mode sanity check
-      shell: bash
+      shell: pwsh
       run: |
-        [ "$(quarto --version)" == "99.9.9" ] || exit 1
-        [ "$(quarto --paths | grep package/dist/share)" == "" ] || exit 1
-        [ "$(git status --porcelain)" == "" ] || exit 1
+        If ( "$(quarto --version)" -ne "99.9.9") { Exit 1 }
+        If ( $(quarto --paths | Select-String -Pattern "package[/\\]+dist[/\\]+share") -ne $null ) { Exit 1 }
+        If ( "$(git status --porcelain)" -ne "" ) { Exit 1 }
 
     - name: Quarto Check
-      shell: bash
-      run: |
-        pushd tests
-        quarto check
-        popd
+      working-directory: tests
+      shell: pwsh
+      run: quarto check

.github/workflows/performance-check.yml

@@ -48,7 +48,7 @@ jobs:
 
           # move the TS file so quarto command will use bundled JS
           mv src/quarto.ts src/quarto1.ts
-          
+
           pushd package/pkg-working/bin
 
           # test a bare quarto command

.github/workflows/test-smokes.yml

@@ -8,16 +8,16 @@ on:
   push:
     # only trigger on branches, not on tags
     branches: [main]
-env:
-  RENV_PATHS_ROOT: ~/.local/share/renv
-
-# Ubuntu: ~/.local/share/renv
-# macOS: ~/Library/Application Support/renv
-# Windows: %LOCALAPPDATA%/renv
+  schedule:
+    - cron: "0 6 * * *"
 
 jobs:
   run-smokes:
-    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, windows-latest]
+    runs-on: ${{ matrix.os }}
 
     steps:
       - name: Checkout Repo
@@ -26,33 +26,62 @@ jobs:
           # checkout full tree
           fetch-depth: 0
 
+      - name: Fix temp dir to use runner one (windows)
+        if: runner.os == 'Windows'
+        run: |
+          echo "TMPDIR=${{ runner.temp }}" >> $GITHUB_ENV
+          echo "TMP=${{ runner.temp }}" >> $GITHUB_ENV
+          echo "TEMP=${{ runner.temp }}" >> $GITHUB_ENV
+        shell: bash
+
       - name: Set up R
         uses: r-lib/actions/setup-r@v2
         with:
           r-version: "4.2.2"
 
       - name: Install node (for Playwright)
+        if: ${{ runner.os != 'Windows' || github.event_name == 'schedule' }}
         uses: actions/setup-node@v3
         with:
           node-version: 16
 
       - name: Install node dependencies
+        if: ${{ runner.os != 'Windows' || github.event_name == 'schedule' }}
         run: yarn
         working-directory: ./tests/integration/playwright
+        shell: bash
 
       - name: Install Playwright Browsers
+        if: ${{ runner.os != 'Windows' || github.event_name == 'schedule' }}
         run: npx playwright install --with-deps
         working-directory: ./tests/integration/playwright
 
-      - name: Cache packages
+      - name: Set RENV_PATHS_ROOT
+        shell: bash
+        run: |
+          echo "RENV_PATHS_ROOT=${{ runner.temp }}/renv" >> $GITHUB_ENV
+
+      - name: Get R and OS version
+        id: get-version
+        run: |
+          cat("os-version=", sessionInfo()$running, "\n", file = Sys.getenv("GITHUB_OUTPUT"), sep = "", append = TRUE)
+          cat("r-version=", R.Version()$version.string, "\n", file = Sys.getenv("GITHUB_OUTPUT"), sep = "", append = TRUE)
+        shell: Rscript {0}
+
+      - name: Cache R packages
         uses: actions/cache@v3
         with:
           path: ${{ env.RENV_PATHS_ROOT }}
-          key: ${{ runner.os }}-1-renv-${{ hashFiles('**/renv.lock') }}
+          key: ${{ steps.get-version.outputs.os-version }}-${{ steps.get-version.outputs.r-version }}-renv-1-${{ hashFiles('renv.lock') }}
           restore-keys: |
-            ${{ runner.os }}-1-renv-
+            ${{ steps.get-version.outputs.os-version }}-${{ steps.get-version.outputs.r-version }}-renv-1-
 
-      - name: Restore packages
+      - name: Install missing system deps
+        if: runner.os == 'Linux'
+        run: |
+          sudo apt-get update -y && sudo apt-get install -y libcurl4-openssl-dev
+
+      - name: Restore R packages
         working-directory: tests
         run: |
           if (!requireNamespace('renv', quietly = TRUE)) install.packages('renv')
@@ -62,18 +91,15 @@ jobs:
       - name: Set up Python
         uses: actions/setup-python@v4
         with:
-          python-version: "3.x"
-          cache: "pip"
+          cache: "pipenv"
+          cache-dependency-path: "./tests/Pipfile.lock"
+          python-version-file: "./tests/.python-version"
 
-      - name: Python Dependencies
+      - name: Restore Python Dependencies
+        working-directory: tests
         run: |
-          pushd tests
-          source bin/activate
-          python3 -m pip install --upgrade pip pip==21.3.1
-          python3 -m pip install wheel
-          python3 -m pip install --user virtualenv
-          python3 -m pip install -r requirements.txt
-          popd
+          python -m pip install pipenv
+          pipenv install --system
 
       - uses: ./.github/workflows/actions/quarto-dev
 
@@ -89,29 +115,49 @@ jobs:
       - name: Setup Julia
         uses: julia-actions/setup-julia@v1
 
-      - name: Julia Packages
+      - name: Cache Julia Packages
+        uses: julia-actions/cache@v1
+
+      - name: Restore Julia Packages
+        working-directory: tests
+        shell: bash
         run: |
-          pushd tests
-          julia --project=. -e "import Pkg; Pkg.instantiate(); Pkg.build(\"IJulia\"); Pkg.precompile()"
-          popd
+          julia --color=yes --project=. -e "import Pkg; Pkg.instantiate(); Pkg.build(\"IJulia\"); Pkg.precompile()"
 
       - name: Smoke Test Commits
         if: github.event.before != ''
         env:
+          # Useful as TinyTeX latest release is checked in run-test.sh
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
           git checkout ${{ github.sha}}
           pushd tests
-          ./run-tests.sh
+          case $RUNNER_OS in
+            "Windows")
+              pwsh -F ./run-tests.ps1
+              ;;
+            *)
+              ./run-tests.sh
+              ;;
+          esac
           popd
+        shell: bash
 
       - name: Smoke Test Head
         env:
           # Useful as TinyTeX latest release is checked in run-test.sh
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         if: github.event.before == ''
         run: |
-          pushd tests
-          quarto render docs/test.qmd --to pdf
-          ./run-tests.sh
-          popd
+          case $RUNNER_OS in
+            "Windows")
+              ../package/dist/bin/quarto.cmd render docs/test.qmd --to pdf
+              pwsh -F ./run-test.ps1
+              ;;
+            *)
+              quarto render docs/test.qmd --to pdf
+              ./run-tests.sh
+              ;;
+          esac
+        working-directory: tests
+        shell: bash

.vscode/launch.json

@@ -11,7 +11,6 @@
       "program": "${workspaceFolder}/src/quarto.ts",
       "args": ["serve"],
       "cwd": "${workspaceFolder}/../quarto-demo",
-      "runtimeExecutable": "deno",
       "runtimeExecutable": "${workspaceFolder}/package/dist/bin/tools/deno",
       "runtimeArgs": [
         "run",
@@ -28,6 +27,34 @@
       "windows": {
         "runtimeExecutable": "${workspaceFolder}\\package\\dist\\bin\\tools\\deno.exe"
       }
+    },
+    {
+      "name": "Run Quarto test",
+      "request": "launch",
+      "type": "node",
+      "program": "smoke/smoke-all.test.ts", // test script here
+      "args": [], // args to the script here, like in command line smoke/smoke-all.test.t -- .\docs\smoke-all\2023\01\19\2107.qmd
+      "cwd": "${workspaceFolder}/tests",
+      "runtimeExecutable": "${workspaceFolder}/package/dist/bin/tools/deno",
+      "runtimeArgs": [
+        "test",
+        "--config=test-conf.json",
+        "--unstable",
+        "--allow-all",
+        "--check",
+        "--importmap=${workspaceFolder}/src/import_map.json",
+        "--inspect-brk"
+      ],
+      "env": {
+        "QUARTO_ROOT": "${workspaceFolder}",
+        "QUARTO_BIN_PATH": "${workspaceFolder}/package/dist/bin",
+        "QUARTO_SHARE_PATH": "${workspaceFolder}/src/resources",
+        "QUARTO_DEBUG": "true"
+      },
+      "attachSimplePort": 9229,
+      "windows": {
+        "runtimeExecutable": "${workspaceFolder}\\package\\dist\\bin\\tools\\deno.exe"
+      }
     }
   ]
 }

configure.cmd

@@ -7,7 +7,8 @@ REM    using ! ! instead of % %. However, this only allows one level of expansio
 REM    try to create a variable that derives from a derived variable. It will be empty.
 
 REM First Check that Deno isn't running since this causes weird and confusing errors
-tasklist /fi "ImageName eq deno.exe" /fo csv 2>NUL | find /I "deno.exe">NUL
+REM find can conflict with one provided in bash with other args so use absolute path
+tasklist /fi "ImageName eq deno.exe" /fo csv 2>NUL | "%WINDIR%/system32/find" /I "deno.exe">NUL
 if "%ERRORLEVEL%"=="0" goto :denoRunning
 
 call package\src\store_win_configuration.bat
@@ -28,7 +29,8 @@ if "%QUARTO_VENDOR_BINARIES%" == "true" (
   CURL --fail -L "https://github.com/denoland/deno/releases/download/!DENO!/!DENO_FILE!" -o "!DENO_FILE!"
   REM Windows doesn't have unzip installed by default, but starting in Windows 10 build 17063 they did 
   REM include a build in 'tar' command. Windows 10 build 17063 was released in 2017.
-  tar -xf !DENO_FILE!
+  REM We need to use absolute if another tar is in PATH, that would not support .zip extension
+  %WINDIR%/System32/tar -xf !DENO_FILE!
 
   REM If tar failed, try unzipping it.
   IF %ERRORLEVEL% NEQ 0 ( 
@@ -86,13 +88,14 @@ ECHO Downloading Deno Stdlib
 CALL !QUARTO_PACKAGE_PATH!\scripts\deno_std\download.bat
 
 SET QUARTO_DENO_EXTRA_OPTIONS="--reload"
-IF EXIST !QUARTO_BIN_PATH!\quarto.bat (
+IF EXIST !QUARTO_BIN_PATH!\quarto.cmd (
   CALL "!QUARTO_BIN_PATH!\quarto" --version
 )
 
-ECHO NOTE: To use quarto please use quarto-cmd (located in this folder) or add the following path to your PATH
+ECHO NOTE: To use quarto please use quarto.cmd (located in this folder) or add the following path to your PATH
 ECHO !QUARTO_BIN_PATH!
 
+endlocal & set QUARTO_BIN_DEV=%QUARTO_BIN_PATH%
 
 GOTO :eof
 

package/src/store_win_configuration.bat

@@ -38,12 +38,12 @@ echo set "QUARTO_ROOT=%%~dp0" >> %~dp0\..\..\win_configuration.bat
 ::    zip file archives that we build.
 
 :: These are the paths within the Quarto source tree - the "package" subfolder.
-echo set "QUARTO_SRC_PATH=%%~dp0\src" >> %~dp0\..\..\win_configuration.bat
-echo set "QUARTO_PACKAGE_PATH=%%~dp0\%%QUARTO_PACKAGE_DIR%%" >> %~dp0\..\..\win_configuration.bat
+echo set "QUARTO_SRC_PATH=%%~dp0src" >> %~dp0\..\..\win_configuration.bat
+echo set "QUARTO_PACKAGE_PATH=%%~dp0%%QUARTO_PACKAGE_DIR%%" >> %~dp0\..\..\win_configuration.bat
 
 :: These paths end up in the output package or conda build prefix.
-echo set "QUARTO_DIST_PATH=%%~dp0\%%QUARTO_PACKAGE_DIR%%\%%QUARTO_DIST_DIR%%" >> %~dp0\..\..\win_configuration.bat
-echo set "QUARTO_SHARE_PATH=%%~dp0\%%QUARTO_PACKAGE_DIR%%\%%QUARTO_DIST_DIR%%\%%QUARTO_SHARE_DIR%%" >> %~dp0\..\..\win_configuration.bat
-echo set "QUARTO_BIN_PATH=%%~dp0\%%QUARTO_PACKAGE_DIR%%\%%QUARTO_DIST_DIR%%\%%QUARTO_BIN_DIR%%" >> %~dp0\..\..\win_configuration.bat
+echo set "QUARTO_DIST_PATH=%%~dp0%%QUARTO_PACKAGE_DIR%%\%%QUARTO_DIST_DIR%%" >> %~dp0\..\..\win_configuration.bat
+echo set "QUARTO_SHARE_PATH=%%~dp0%%QUARTO_PACKAGE_DIR%%\%%QUARTO_DIST_DIR%%\%%QUARTO_SHARE_DIR%%" >> %~dp0\..\..\win_configuration.bat
+echo set "QUARTO_BIN_PATH=%%~dp0%%QUARTO_PACKAGE_DIR%%\%%QUARTO_DIST_DIR%%\%%QUARTO_BIN_DIR%%" >> %~dp0\..\..\win_configuration.bat
 
 echo "Translated/recorded configuration settings from unix configuration script"

src/command/render/resources.ts

@@ -6,9 +6,12 @@
 */
 
 import { dirname, join } from "path/mod.ts";
-import { existsSync } from "fs/mod.ts";
-
-import { normalizePath, ResolvedPathGlobs, resolvePathGlobs } from "../../core/path.ts";
+import {
+  normalizePath,
+  ResolvedPathGlobs,
+  resolvePathGlobs,
+  safeExistsSync,
+} from "../../core/path.ts";
 import { engineIgnoreGlobs } from "../../execute/engine.ts";
 import { kQuartoScratch } from "../../project/project-scratch.ts";
 import { extractResolvedResourceFilenamesFromQmd } from "../../execute/ojs/extract-resources.ts";
@@ -105,7 +108,7 @@ export async function resourceFilesFromFile(
   if (!selfContained) {
     const resultFiles = resources.files
       .map((file) => join(resourceDir, file))
-      .filter(existsSync)
+      .filter(safeExistsSync)
       .map(normalizePath);
     fileResourceFiles.include.push(...resultFiles);
   }

src/extension/extension-host.ts

@@ -36,7 +36,7 @@ export interface ExtensionSource {
 export async function extensionSource(
   target: string,
 ): Promise<ExtensionSource | undefined> {
-  if (existsSync(target)) {
+  if (!target.match(/^https?:\/\/.*$/) && existsSync(target)) {
     return { type: "local", resolvedTarget: target };
   }
 

tests/.gitignore

@@ -0,0 +1,11 @@
+# Python Environments
+.env
+.venv
+env/
+venv/
+ENV/
+env.bak/
+venv.bak/
+
+bin/
+/.luarc.json

tests/.python-version

@@ -0,0 +1 @@
+3.11.1