Do not error on file existence when filtering resources #4255
Conversation
Local resources files won't be found as `images/beach.jpg?bar` is not a file. It errors on Windows (not on Linux)
|
It does seem like local paths do not need to support query params in this way- I think it's fine to remove this from the test. This does, to me, seem like a possible place to use safeExistsSync() since our point of view is that this couldn't be a valid file path (not that it should throw). Theoretically, someone could likely form a valid relative path to a file that will be present when deployed on a server which contains a query param which would be properly interpreted in the context of deployment (making the path a valid href, but not a valid local file path)... |
yes that was my thinking too. This would work with Pandoc I guess only with Otherwise, Pandoc will try to insert something to encode and failed. But I still think we should support - I'll fix with |
This reverts commit 50757a7 as we should try support this specific use case by fixing code instead.
|
So I made the modification. I believe this will "solve" also #4194 (comment) by hiding the problem there. The is the issue with |
|
So I will merge this but it will hide the other issue. We just need to remember. |
cderv
changed the title
THIS PR IS AGAINST WINDOWS TESTS BRANCH
Local resources files won't be found as
images/beach.jpg?baris not a file. It errors on Windows (not on Linux).Here I tweak test, as I don't think this is something we should really supports. Should we ?
I mean
points a no real file and self contained will fail because image detected is not
beach.jpgbutbeach.jpg?barIf such local URL needs to be supported somehow, then we should parse resources by removing URL parameters.
Just want to check that before committing.
What are your thought @dragonstyle ?