Ensure that the figure/fig-cap pair is laid out as consecutive paragraphs in docx #4584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscheid
reviewed
Mar 1, 2023
Collaborator
cscheid
left a comment
cscheid
left a comment
There was a problem hiding this comment.
Great. I think all we need is
- to make sure that the test is checking for the correct fix
- add an entry to
news/changelog-1.3.md
Collaborator
|
I'm freezing this PR until I get the crossref work done and integrated in 1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that figures are no longer laid out within a table when paired with a figure caption (in the docx output format). The advantage of the table layout was that the caption was guaranteed to be 'kept with' the figure (i.e., not be orphaned across pages). We can keep that functionality in consecutive paragraphs here by applying the
keepNextparagraph property.We ensure that the alignment property is captured and used for the caption. Furthermore the figure caption location (top or bottom) is respected here. The caption text is styled with
"Caption"which provides the same appearance as a table caption.A .qmd file that exercises all of the options has been placed in the appropriate smoke tests directory.
Fixes: #4004