Correctly unset citeproc meta if set by user as we use filter #5588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deactivating citeproc should happen in allDefaults options that will be used for default files
fixes #5585
As mentioned there in #5585 (comment)
The regression was a side effect of this change I made as
resolvedFilters()which happens now on a cloned version of optionsquarto-cli/src/command/render/defaults.ts
Lines 43 to 53 in 8781ac3
This change was done in #4348 to fix #4260 after a discussion with @dragonstyle
I added a regression test so that we don't mess with this again.
This is happening with 1.3 and 1.4. This should probably be a hot fix in 1.3. I don't know how you handle that usually. This PR is again main, and I supposed you cherry-pick for a new 1.3 release ? Where should the bullet news be in that case ?
@dragonstyle @jjallaire I let you check this change, and do the right thing for the patch if needed.