Skip to content

Website - Check title before overwriting with rendered #8430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Website - Check title before overwriting with rendered #8430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions news/changelog-1.5.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All changes included in 1.5:

- ([#8118](https://github.com/quarto-dev/quarto-cli/issues/8118)): Add support for `body-classes` to add classes to the document body.

## Website

- ([#7318](https://github.com/quarto-dev/quarto-cli/issues/7318)): Don't improperly overwrite page titles

## Other Fixes

- ([#8119](https://github.com/quarto-dev/quarto-cli/issues/8119)): More intelligently detect when ejs templates are modified during development, improving quality of life during preview.
6 changes: 4 additions & 2 deletions src/project/types/website/website-meta.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,10 +432,12 @@ const kOgTitle = "quarto-ogcardtitle";
const kOgDesc = "quarto-ogcardddesc";
const kMetaSideNameId = "quarto-metasitename";
function metaMarkdownPipeline(format: Format, extras: FormatExtras) {
const resolvedTitle = computePageTitle(format);

const titleMetaHandler = {
getUnrendered() {
const inlines: Record<string, string> = {};
const resolvedTitle = computePageTitle(format);

if (resolvedTitle !== undefined) {
inlines[kMetaTitleId] = resolvedTitle;
}
Expand All @@ -455,7 +457,7 @@ function metaMarkdownPipeline(format: Format, extras: FormatExtras) {
const el = doc.querySelector(
`head title`,
);
if (el) {
if (el && el.innerText === resolvedTitle) {
if (format.pandoc[kNumberSections] === false) {
// Remove chapter numbers if not numbered
const numberEl = renderedEl.querySelector("span.chapter-number");
Expand Down