Parsed HTML table wrapping div needs to be scaffold so that it is removed #9602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
cderv
changed the title
Contributor
|
This also fixes #8797 |
Collaborator
|
Yes, let's backport it. |
Collaborator
|
Will this also close #6529? |
Especially because powerpoint does not allow Div and Tables in Div
Ensure the figure is not wrap in a block that prevents the alignment to work. This #block was created by the unneeded `Div` that is now a scaffolded one.
Collaborator
Author
Thanks @gordonwoodhull. I commented at #8797 (comment). I think this is fixed by prerelease already for what is reported. Though I added a test for typst here, because parsed HTML table where also an issue leading to aligned table. It seems center align is our default for Typst in 1.5. |
Collaborator
Author
cderv
added a commit
that referenced
this pull request
May 14, 2024
- Use scaffoled Divs for parsed HTML table so that it is removed and not converted in output format - Use make_scaffold as _quarto.ast.scafold_element does not exist in 1.4 - Add a test for powerpoint using XPATH - Add a test for typst table Ensure the figure is not wrap in a block that prevents the alignment to work. This #block was created by the unneeded `Div` that is now a scaffolded one.
cderv
added a commit
that referenced
this pull request
May 14, 2024
- Use scaffolded Divs for parsed HTML table so that it is removed and not converted in output format - Use make_scaffold as _quarto.ast.scafold_element does not exist in 1.4 - Add a test for powerpoint using XPATH - Add a test for typst table Ensure the figure is not wrap in a block that prevents the alignment to work. This #block was created by the unneeded `Div` that is now a scaffolded one.
Collaborator
Author
|
This was backported in 1.4 for next patch release, and changelog added there. Merging this in main now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially because powerpoint does not allow Div and Tables in DivWelcome to the quarto GitHub repo!
fixes #9365