fix: quarto preview in Windows/PowerShell #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Windows-specific execution of preview command to properly handle for file paths with spaces. Also surround the path with quotes.
jmbuhr
changed the title
Collaborator
|
Thanks, that's a great addition! |
Contributor
Author
|
@jmbuhr Happy to help. Thanks for developing this plugin! |
bkp5190
pushed a commit
to bkp5190/quarto-nvim
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34. This appears to be a Windows/PowerShell-specific issue so I try to contain this to just Windows. I change how file paths passed to
quartoPreview()are handled to resolve the issue while still accounting for spaces in the file path. Let me know what you think.