Help topic provider with doc #601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
CC @lionel- too, just as an FYI since we've talked about this in the past a bit |
juliasilge
approved these changes
Nov 9, 2024
Collaborator
juliasilge
left a comment
juliasilge
left a comment
There was a problem hiding this comment.
Nice! That is going to work well.
juliasilge
added a commit
that referenced
this pull request
Nov 9, 2024
* Add new help topic provider for Quarto files * Fix up return * Help topic provider with doc (#601) * More usefully define `withVirtualDocUri()` * Use `withVirtualDocUri()` in `provideHelpTopic()` * Use new version of `withVirtualDocUri()` for statement range provider as well * Update changelog --------- Co-authored-by: Davis Vaughan <davis@posit.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched from #599
@juliasilge what do you think about this?
withVirtualDocUri()is now in charge of both:virtualDocUri()This prevents any kind of leakage of temp files from occurring.
After this we should try and go back and use
withVirtualDocUri()instead ofvirtualDocUri()everywhere and then makevirtualDocUri()private.withVirtualDocUri()could also provide an error hook if a user needs to control the} catch (error) {case too, but I'd only add that later on if it turns out we need it.