Hide diagnostics from virtual documents #832
Merged
+88
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
approved these changes
Oct 1, 2025
apps/vscode/package.json
Outdated
Comment on lines
1048
to
1054
| "quarto.vdoc.hideDiagnostics": { | ||
| "order": 26, | ||
| "scope": "window", | ||
| "type": "boolean", | ||
| "default": true, | ||
| "markdownDescription": "Hide diagnostics (problems) reported for internal virtual document files. These are temporary files used to provide language features in code blocks." | ||
| }, |
There was a problem hiding this comment.
I don't think I see any reason to have this option
In the long term I'd actually like if Quarto didn't generate virtual docs at all, which would render this option kind of useless anyways!
There was a problem hiding this comment.
That's a great point! If we're trying to deal with problems in this area, then we're just using a dev build anyway.
There was a problem hiding this comment.
Apologies for reviving a closed PR conversation, but @DavisVaughan do you have something in mind for replacing virtual docs?
apps/vscode/src/vdoc/vdoc.ts
Outdated
Comment on lines
57
to
66
| export function isVirtualDoc(uri: Uri): boolean { | ||
| // Check for tempfile virtual docs | ||
| if (uri.scheme === "file") { | ||
| const filename = path.basename(uri.fsPath); | ||
| // Virtual docs have a specific filename pattern .vdoc.[uuid].[extension] | ||
| return filename.startsWith(".vdoc.") && filename.split(".").length > 3; | ||
| } | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
Would you mind placing this alongside generateVirtualDocFilepath()? That is where we actually generate the file path, so that would help us keep these in sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #819, which has been quite a bear in real work! Many, many diagnostics from our
vdocfiles, every time you save a file with a syntax error in it. 😱It turns out the
Middlewarefrom "vscode-languageclient" already has a way to doHandleDiagnosticsSignature, so this was fairly straightforward.I will get started on using Claude to write an extension test for this.