Undo onDidSaveTextDocument that causes problems for ALL files in VS Code
#848
+13
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasilge
changed the title
onDidSaveTextDocument that causes problems for _all_ filesonDidSaveTextDocument that causes problems for _all_ files in VS Code
juliasilge
changed the title
onDidSaveTextDocument that causes problems for _all_ files in VS CodeonDidSaveTextDocument that causes problems for ALL files in VS Code
|
We can confirm the fix by getting the artifact from here: https://github.com/quarto-dev/quarto/actions/runs/18350404038/job/52268505072?pr=848 Download, unzip, then Extensions: Install from VSIX... |
|
You should still be able to switch between visual and source mode in VS Code, but you should not see any attempts to open in visual mode in non-Quarto files on a save. |
cderv
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #845
This PR undoes the change in 6b416d3 that accidentally set up
onDidSaveTextDocumentthat applies to all documents. This bug was in a code path that only applied to VS Code.