Skip to content

Conversation

@diego-treitos
Copy link
Contributor

@diego-treitos diego-treitos commented Jan 12, 2023

Q A
Bug fix? yes?
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets ??
Related issues/PRs ??
License MIT

What's in this PR?

I added the ffmpeg parameter adaptation_sets for dash streams

Why?

When testing DASH mpd generated by this project, the different qualities (representations) were not properly recognized in the dash.js reference player: http://reference.dashif.org/dash.js/nightly/samples/dash-if-reference-player/index.html

I tested with other players and none of them recognized the different representations until I added the adaptation_sets parameter.

BC Breaks/Deprecations

Probably breaks support for subtitles? I am not sure if it is even supported by the project.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 12, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.05%.

Quality metrics Before After Change
Complexity 1.37 ⭐ 1.37 ⭐ 0.00
Method Length 51.00 ⭐ 51.18 ⭐ 0.18 👎
Working memory 5.93 ⭐ 5.93 ⭐ 0.00
Quality 83.03% 82.98% -0.05% 👎
Other metrics Before After Change
Lines 132 133 1
Changed files Quality Before Quality After Quality Change
ffmpeg_streaming/_command_builder.py 83.03% ⭐ 82.98% ⭐ -0.05% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
ffmpeg_streaming/_command_builder.py _get_hls_stream 0 ⭐ 121 😞 8 🙂 70.53% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@aminyazdanpanah aminyazdanpanah merged commit 3105a87 into quasarstream:master Apr 9, 2023
@aminyazdanpanah
Copy link
Member

Thank you for your contribution.
it can also be modified this value by using the following code:

dash = video.dash(Format.h264(), adaptation_sets="ANY_VALUE")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants