Added adaptation_sets parameter for ffmpeg #106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
I added the ffmpeg parameter
adaptation_setsfor dash streamsWhy?
When testing DASH
mpdgenerated by this project, the different qualities (representations) were not properly recognized in the dash.js reference player: http://reference.dashif.org/dash.js/nightly/samples/dash-if-reference-player/index.htmlI tested with other players and none of them recognized the different representations until I added the
adaptation_setsparameter.BC Breaks/Deprecations
Probably breaks support for subtitles? I am not sure if it is even supported by the project.