Conversation
sjakobi
force-pushed
the
drop-ghc-7-compat
branch
4 times, most recently
from
2dfd48e to
05bc7a7
Compare
Follow-up to 92cc704 (drop GHC 7 support). Remove code that was only needed for GHC versions older than 8: - Remove CPP macros always true with base >= 4.9: APPLICATIVE_MONAD, FUNCTOR_IDENTITY_IN_BASE, MONOID_IN_PRELUDE, NATURAL_IN_BASE, SEMIGROUP_IN_BASE - Remove conditional dependencies on semigroups, fail, void, ghc-prim - Always enable -Wcompat (was conditional on GHC >= 8.0) - Remove doctest buildability conditions for GHC < 7.10 - Remove unused Control.Applicative imports (in Prelude since base 4.8) Assisted-by: GLM-5 <noreply@fireworks.ai>
sjakobi
force-pushed
the
drop-ghc-7-compat
branch
from
05bc7a7 to
9de99fd
Compare
a-02
reviewed
Apr 15, 2026
Collaborator
a-02
left a comment
a-02
left a comment
There was a problem hiding this comment.
Looks a lot cleaner. Less stuff to worry about is always good.
Comment on lines
+46
to
+47
| -- Note: 'split' is deprecated in random >= 1.2 in favor of 'splitGen'. | ||
| -- We could use 'splitGen' when support for GHC < 9.0 is dropped. |
Collaborator
Author
There was a problem hiding this comment.
Not really. I would like to keep support for GHC 8 at least for the 1.8 release.
When keeping the compatibility becomes very onerous I don't mind dropping it.
Collaborator
There was a problem hiding this comment.
Fair, support for <9.0 isn't too hard (at the moment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.