Is anyone currently using these CLI commands? #310
Replies: 2 comments 1 reply
-
|
I am going to be honest: I didn't know these CLI commands existed, meaning I've never used them. When looking into specific coverage files, I have mostly used the I see your point about why these CLI commands are not compatible with a future PyPI release, so I'm completely fine with replacing them with development documentation. |
Beta Was this translation helpful? Give feedback.
-
|
Some realisation I had after posting:
|
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Is anyone currently using the coverage report CLI commands in their development workflow?
If I propose to replace them with documentation in a readme.
Here are my thought on why:
I am talking about the following CLI utilities in
pyproject.toml:which are defined in
src/queens/utils/cli.pyI am sure these helpers have served (or may still serve) as a useful convenience and abbreviation for developers working in the repository. However, given the goal of distributing QUEENS as an installable package, I am not convinced they still belong in the public CLI.
My reasoning is that these utilities are tightly coupled to the repository structure and development environment rather than to end-user functionality. In particular, they rely on
PATH_TO_ROOTand assume a specific repository layout. This works for local development inside the QUEENS repository, but it would not make much sense for a user who installs QUEENS via pip from PyPI, where the source root is not available in the same way.Generating and cleaning coverage reports is primarily a developer task.
Therefore, I would suggest removing these commands from the codebase and instead documenting the recommended workflow for generating coverage reports during local development. Such documentation could either mirror the CI configuration or explicitly reference it. This would also avoid potential confusion if the CLI implementation and the CI pipeline ever diverge.
An alternative solution might be to introduce CLI development commands, if that is possible.
In that case, I still suggest moving the code to a different location though, probably in the
test_utilsfolder.What do you think? Are these commands still actively used, or would moving this functionality into the developer documentation be a reasonable cleanup?
Beta Was this translation helpful? Give feedback.
All reactions