Skip to content

Using createPortal for modal #98

@invisal

Description

@invisal

Currently, our modal is placed in the closest parent element. This is not ideal as the parent element style can affect the modal. We should render the modal inside the body as direct parent.

We can achieve this using createPortal. This will provide more consistence experience

Where to implement
https://github.com/invisal/query-master/blob/main/src/renderer/components/Modal/index.tsx

This is our modal code. You can make change here.

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions