feat: added enum completion #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Oh no, should I have included the package.json in my pull request? |
invisal
requested changes
Aug 6, 2023
| const enumValues = enumSchema.find((tempEnum) => { | ||
| if (column) { | ||
| // normally column will be enum | ||
| return tempEnum.column === column.replaceAll('`', ''); |
Collaborator
There was a problem hiding this comment.
It would be expensive to repeating replaceAll which can just do it one time at the top.
Contributor
Author
There was a problem hiding this comment.
How did I not think of this? 😱
Contributor
Author
There was a problem hiding this comment.
I have moved replaceAll higher up
Contributor
Author
|
I have changed the code as per your suggestion. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review carefully, Im not sure where to put helper functions and types. I wanted to break the function into smaller functions, so that it would be easier to read.