Skip to content

chore: allow external Buffer flushability checking #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025
Merged

chore: allow external Buffer flushability checking #101

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37fa57b
Added `Buffer::check_can_flush`
ischeinkman May 7, 2025
ca12ca8
Remove transaction logic from the flush fn
ischeinkman May 7, 2025
3b297f2
Merge remote-tracking branch 'origin/main' into allow-external-flush-…
amunra May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion questdb-rs/src/ingress/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,15 @@ impl Buffer {
}
}

/// Checks if this buffer is ready to be flushed to a sender via one of the
/// [`Sender::flush`] functions. An [`Ok`] value indicates that the buffer
/// is ready to be flushed via a [`Sender`] while an [`Err`] will contain a
/// message indicating why this [`Buffer`] cannot be flushed at the moment.
#[inline(always)]
pub fn check_can_flush(&self) -> Result<()> {
self.check_op(Op::Flush)
}

#[inline(always)]
fn validate_max_name_len(&self, name: &str) -> Result<()> {
if name.len() > self.max_name_len {
Expand Down Expand Up @@ -2585,7 +2594,7 @@ impl Sender {
"Could not flush buffer: not connected to database."
));
}
buf.check_op(Op::Flush)?;
buf.check_can_flush()?;

if buf.len() > self.max_buf_size {
return Err(error::fmt!(
Expand Down