-
Notifications
You must be signed in to change notification settings - Fork 22
Improve docs on the ingress module #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
amunra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Substantial improvements.
Some minor tweaks recommended.
Note that the C, C++ and FFI doc strings probably need updating as well: I've been trying to keep them in sync.
|
Clarification: I had written feedback about reverting |
|
I had a specific reason to use |
|
|
|
Sorry. Correct. Need to enable at least webpki-roots. |
|
My guess is that there's something wrong with the isolation between tests. I suppose this test should create its own table, but it seems to already exist and there's a type clash on column |
|
Working on the docs, I noticed that |
|
I think the Ingress doc is missing a chapter on error handling. there is only this:
A good understanding of error handling is critical for successful usage. Something like this: https://py-questdb-client.readthedocs.io/en/latest/sender.html#error-reporting Or here is Java: https://questdb.io/docs/clients/java_ilp/#error-handling |
jerrinot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall it's a pretty great improvement!
I see only two bigger things:
- consider deemphasizing the TCP transport. Move it from the Getting Started chapter (=the material for absolute beginners, it's OK to be opinionated there)
- explain error handling in the Rust Ingres docs. I think that's pretty important for production usage.
Closes #61. Closes #60.