-
Notifications
You must be signed in to change notification settings - Fork 10
feat: support decimal #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RaphDal
wants to merge
13
commits into
main
Choose a base branch
from
rd_decimal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,200
−108
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
dc15bfb
feat: support decimal
RaphDal c186a73
refactor: remove unused constant for decimal type code
RaphDal 6c3459f
docs: clarify comment on NewScaledDecimal regarding nil/empty unscale…
RaphDal f486bab
refactor: simplify protocol version handling in integration tests
RaphDal 100bba6
fix: update error message for decimal value size limit
RaphDal 5a3e29b
fix: improve validation for decimal text exponent handling
RaphDal b2e697e
fix: handle null decimals and improve error reporting in DecimalColumn
RaphDal a1c3981
fix: remove unnecessary check for mantissa digits in decimal validation
RaphDal d2b6670
refactor: rework decimal integration to conform to other types
RaphDal a7f4c07
fix: handle null decimals in DecimalColumn methods to prevent writing…
RaphDal b6e5de3
fix: adjust twos complement return value for zero in bigIntToTwosComp…
RaphDal f3222af
fix: correct method name in LineSender interface documentation
RaphDal 8405773
fix: rename IsNull method to isNull for consistency in ScaledDecimal
RaphDal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point, we already wrote column name to the buffer. ILP requires the value to be included. Can't we interpret zero length as null on the server side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we don't even need to send the value.
In the fix, we no longer send the field if the value is null.