Skip to content

Hook direkt in dist schreiben lassen und danach validieren #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 31, 2025
Merged

Hook direkt in dist schreiben lassen und danach validieren #206

merged 11 commits into from
Jul 31, 2025

Conversation

@MHajoha
Copy link
Member

@MHajoha MHajoha commented Jun 27, 2025 •
edited
Loading

  • Auch wenn ein Zip-Paket gebaut wird, wird das dist-Verzeichnis jetzt erst in einem temporären Verzeichnis angelegt, und erst nach Ende des Build-Prozesses paketiert. Ich habe auch etwas refactored und die Unterschiede zwischen ZIP und Dir-Build in DirBuildTarget und ZipBuildTarget geschmissen
  • Build-Hooks erhalten jetzt die Umgebungsvariablen QPY_DIST, QPY_DIST_JS, QPY_DIST_CSS, QPY_SOURCE. Ich kann mir vorstellen, dass es für überraschend sein kann, das in Source direkt js/ und css/, aber in dist static/js/ und static/css/ verwendet werden, daher die _JS und _CSS Variablen.
  • Außerdem, um Paketentwickler:innen sofort aufzuzeigen, wenn sie Dinge an falsche orte schreiben, wird das dist-Verzeichnis nach dem Build validiert und sowohl fehlende als auch überflüssige Dateien als Warnungen geloggt.

Closes: #174

janbritz
janbritz approved these changes Jul 3, 2025
View reviewed changes
@MHajoha MHajoha force-pushed the hook-build-into-dist branch from 373ffb1 to 3d83e20 Compare July 7, 2025 12:08
@MHajoha MHajoha linked an issue Jul 7, 2025 that may be closed by this pull request
Isoliertes Paket-Build-Environment #174
Closed
tumidi
tumidi requested changes Jul 7, 2025
View reviewed changes
@MHajoha MHajoha force-pushed the hook-build-into-dist branch from 3d83e20 to 3c4a467 Compare July 11, 2025 15:14
@MHajoha MHajoha requested a review from tumidi July 14, 2025 13:11
@MHajoha MHajoha mentioned this pull request Jul 15, 2025
Merged
tumidi
tumidi requested changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@tumidi tumidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

siehe #206 (comment)

@MHajoha MHajoha requested a review from tumidi July 21, 2025 16:12
tumidi
tumidi requested changes Jul 22, 2025
View reviewed changes
@MHajoha MHajoha requested a review from tumidi July 22, 2025 11:45
@MHajoha MHajoha merged commit 3b50b76 into dev Jul 31, 2025
12 checks passed
@MHajoha MHajoha deleted the hook-build-into-dist branch July 31, 2025 11:22
@MartinGauk MartinGauk mentioned this pull request Aug 4, 2025
Closed
@janbritz janbritz mentioned this pull request Aug 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinGauk MartinGauk MartinGauk approved these changes

@tumidi tumidi tumidi approved these changes

@janbritz janbritz janbritz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Isoliertes Paket-Build-Environment

5 participants

@MHajoha @MartinGauk @tumidi @janbritz