Removed redundant input_length column from dataset. #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
quic-meetkuma
commented
Sep 1, 2025
quic-meetkuma
commented
- This is required because, whenever dataset padding is performed there will be an additional input being fed to the model. For causal lm models somehow this did not gave any error. But for BERT kind of models this gave error.
quic-meetkuma
requested review from
ochougul,
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
Signed-off-by: meetkuma <meetkuma@qti.qualcomm.com>
quic-meetkuma
force-pushed
the
dataset_fix
branch
from
0d203b0 to
7cde487
Compare
quic-swatia
approved these changes
Sep 1, 2025
Contributor
quic-swatia
left a comment
quic-swatia
left a comment
There was a problem hiding this comment.
Change looks good to me. Meet confirmed that change works well with PFT FT as well. :)
ochougul
pushed a commit
that referenced
this pull request
Nov 3, 2025
- This is required because, whenever dataset padding is performed there will be an additional input being fed to the model. For causal lm models this did not gave any error as its forward methods has kwargs which caught unnecessary arguments. But for BERT kind of models this gave error. Signed-off-by: meetkuma <meetkuma@qti.qualcomm.com> Signed-off-by: Onkar Chougule <ochougul@qti.qualcomm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.