#376 breaks AcceptorTemplate

[jimbogithub]

Describe the bug
#376 appears to break AcceptorTemplates. Specifically the moving of this line:

AcceptorSocketDescriptor descriptor = getAcceptorSocketDescriptor(settings, sessionID);

in quickfix.mina.acceptor.AbstractSocketAcceptor to inside the if (!isTemplate) { block means that the later

 if (socketDescriptorForAddress.isEmpty()) {
    throw new ConfigError("No acceptor sessions found in settings.");
 }

always throws an error if the only Session is the template.

[chrjohn]

Hi @jimbogithub , thanks for catching this. 👍
Would've been bad if this got into the release. Seems the test coverage around the AcceptorTemplate is insufficient. Will take a look at it.
Are you able to test a fix?

[chrjohn]

quickfixj/quickfixj-core/src/main/java/quickfix/mina/acceptor/AbstractSocketAcceptor.java

Lines 241 to 242 in 1126a4f

	if (!isTemplate) {
	AcceptorSocketDescriptor descriptor = getAcceptorSocketDescriptor(settings, sessionID);

Unfortunately getAcceptorSocketDescriptor() adds a descriptor to a map which was unexpected for me when reading the method name. :-/

[chrjohn]

Opened #386 which currently only contains unit test to highlight problematic behaviour. Will add rest later.

[jimbogithub]

Are you able to test a fix?

Yes, I have a test in my own system that will pass/fail this.

[chrjohn]

Great, will merge in the next two hours or so. Guess that will not make things worse.

[chrjohn]

@jimbogithub , I have merged now.

[jimbogithub]

@chrjohn Thanks, my tests pass.

[chrjohn]

Great, thanks for the heads-up. 👍