QFJ-169 / QFJ-791: support unknown tags in repeating groups #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apply validation settings to all groups
- extended Message.parseGroup() to accept unknown fields in repeating groups - if validation is disabled (either completely or depending on ValidateUserDefinedFields or AllowUnknownMsgFields) - if the field encountered is not a trailer or message field - moreover, if validation is enabled, the incorrect field will be reported (not the next field that is encountered) - added unit tests from QFJ issues - removed synchronization from FieldException in Message since it seemed unnecessary
chrjohn
added a commit
that referenced
this pull request
Apr 5, 2017
QFJ-169 / QFJ-791: support unknown tags in repeating groups (cherry picked from commit ceb3e9d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.