Skip to content

Conversation

@chrjohn
Copy link
Member

@chrjohn chrjohn commented Oct 19, 2020

No description provided.

@chrjohn chrjohn added this to the QFJ 2.2.1 milestone Oct 19, 2020
try to make MAVEN_OPTS work on Windows
@chrjohn chrjohn changed the title Created maven.yml for github ci workflow Created maven.yml for GitHub CI workflow Oct 19, 2020
@the-thing
Copy link
Contributor

Hi @chrjohn,

I can see why some of these tests are failing. I will be coming up with patches shortly.

@chrjohn
Copy link
Member Author

chrjohn commented Oct 19, 2020 via email

@the-thing
Copy link
Contributor

Yes, this is a comparison error, but it happens, because there is a small difference in behaviour in javax.xml.transform.Transformer between Java 8 & 11. There will be an additional one line code change to fix this for all versions.

@chrjohn chrjohn merged commit 0c22df4 into master Oct 20, 2020
@chrjohn chrjohn deleted the chrjohn-github-ci-workflow branch October 20, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants