Skip to content

Conversation

@philipwhiuk
Copy link
Contributor

Fixed #477

@chrjohn
Copy link
Member

chrjohn commented Sep 12, 2022

Hi @philipwhiuk , I've just merged #380 .
So it should be a matter of creating your own queue implementation with an enqueue method similar to this:

public void enqueue(int sequence, Message message) {
    if (backingMap.size() < maxMessagesQueuedWhilePendingResend || maxMessagesQueuedWhilePendingResend == -1) {
        backingMap.put(sequence, message);
    }
}

Do you think it is OK to close this PR then? Would you like to submit a PR with a queue implementation that is limited in size?
Thanks,
Chris.

@philipwhiuk
Copy link
Contributor Author

Hi Chris, Yeah, I'll look at creating a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SessionState#messageQueue is unbound

2 participants