Skip to content

Conversation

@cbusbey
Copy link
Contributor

@cbusbey cbusbey commented Apr 30, 2016

@bhaan
Copy link
Contributor

bhaan commented May 1, 2016

Do you think it would be sensible to also expose the rejectReason enum values?

I'm in the process of testing some error scenarios, and it seems logical to confirm the reject reason is what I expect it to be. The MessageRejectError interface provides an exposed RejectReason() int function, but the hidden enum values prevent me from making these assertions in a type safe way.

@cbusbey
Copy link
Contributor Author

cbusbey commented May 2, 2016

Possibly... The reject reasons are not comprehensive though. The enum package has all of them

Caveat being that these are strings.

@cbusbey cbusbey merged commit 3a9e364 into quickfixgo:master May 5, 2016
@cbusbey cbusbey deleted the expose_rejects branch May 5, 2016 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants