Skip to content

Conversation

@cbusbey
Copy link
Contributor

@cbusbey cbusbey commented May 25, 2016

In practice, this seems to be the more code friendly impl:

//NewAccount returns a new AccountField initialized with val
func NewAccount(val string) AccountField {
    return AccountField{quickfix.FIXString(val)}
}

vs.

//NewAccount returns a new AccountField initialized with val
func NewAccount(val quickfix.FIXString) AccountField {
    return AccountField{val}
}

The latter forces some type gymnastics in most common cases where we have a string var to pass into NewAccount.

@mgatny
Copy link
Member

mgatny commented May 25, 2016

👍 LGTM once it passes on CI

@mgatny mgatny merged commit dcbb623 into quickfixgo:master May 25, 2016
@cbusbey cbusbey deleted the slight_gen_revert branch May 25, 2016 13:38
@cbusbey cbusbey added this to the v0.3.0 milestone Jun 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants