updated templated to include beginstring on New

[britzc]

Added a beginstring when messages are instantiated through New

[cbusbey]

@britzc thanks for the pr. I have a couple of comments about this contribution after digging into it further.

First, it looks like this code would work for FIX4* but not FIX 5+. Beginning in FIX50, the BeginString is set as FIXT1.1 and uses on the ApplVerID to specify the application version of the message itself. Admittedly, the routing logic uses some confusing variable names to account for this, but it does treat FIXT1.1 begin string messages correctly.

Second, I'm curious what the use case is for setting the BeginString at message generation is. Currently, QuickFIX does this for you when you send a message to a Session. So really even if you do set the begin string in generated code, or manually, the QuickFIX session code will populate these fields based on the session information again (btw, this is the same approach taken by the original QuickFIX library). Are you using the generated code but not sending it via QuickFIX?

[britzc]

Hi, will have a look tonight and thanks for the feedback.

Where the beginstring concern becomes evident, is when my client library has to perform routing through unit tests, which fails as the beginstring and msgtype is required.

Regards
Corneile

Sent from my iPhone

On 14 Jul 2016, at 15:53, Chris Busbey notifications@github.com wrote:

@britzc thanks for the pr. I have a couple of comments about this contribution after digging into it further.

First, it looks like this code would work for FIX4* but not FIX 5+. Beginning in FIX50, the BeginString is set as FIXT1.1 and uses on the ApplVerID to specify the application version of the message itself. Admittedly, the routing logic uses some confusing variable names to account for this, but it does treat FIXT1.1 begin string messages correctly.

Second, I'm curious what the use case is for setting the BeginString at message generation is. Currently, QuickFIX does this for you when you send a message to a Session. So really even if you do set the begin string in generated code, or manually, the QuickFIX session code will populate these fields based on the session information again (btw, this is the same approach taken by the original QuickFIX library). Are you using the generated code but not sending it via QuickFIX?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[cbusbey]

Closing in favor of #184