Reset peer timer after logon #171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing a test request (35=1) being sent immediately after logon for our acceptor. After looking into this, it appears that the
peerTimerwas being reset before having processed the logon request form the initiator. Because the initiator's logon contains the heartbeat interval, the acceptor was trying to reset the timer with a zero value, ultimately causing the peer timer to activate immediately.The following changes will prevent timers from being reset with a zero value, and ensures that the timer is reset once the logon (and heartbeat interval) is received.