Skip to content

Conversation

@bhaan
Copy link
Contributor

@bhaan bhaan commented Jul 15, 2016

We were seeing a test request (35=1) being sent immediately after logon for our acceptor. After looking into this, it appears that the peerTimer was being reset before having processed the logon request form the initiator. Because the initiator's logon contains the heartbeat interval, the acceptor was trying to reset the timer with a zero value, ultimately causing the peer timer to activate immediately.

The following changes will prevent timers from being reset with a zero value, and ensures that the timer is reset once the logon (and heartbeat interval) is received.

@cbusbey cbusbey added the Bug Behavior not matching expected label Jul 15, 2016
@cbusbey cbusbey added this to the v0.4.0 milestone Jul 15, 2016
@cbusbey cbusbey merged commit 1c4c5f9 into quickfixgo:master Jul 15, 2016
@bhaan bhaan deleted the peer-timer branch July 15, 2016 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Behavior not matching expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants