Skip to content

Fix time range #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2016
Merged

Fix time range #239

merged 2 commits into from
Aug 30, 2016

Conversation

@teloon
Copy link

@teloon teloon commented Aug 29, 2016

say the startDay==endDay==Sunday, the current day is Monday. it should return false unless startTime >= endTime

@cbusbey cbusbey added the Bug Behavior not matching expected label Aug 30, 2016
@cbusbey cbusbey added this to the v0.5.0 milestone Aug 30, 2016
@cbusbey
Copy link
Contributor

cbusbey commented Aug 30, 2016

Definitely a quirky edge case you found there... Thanks for the fix! 🍻
Refs #31

@cbusbey cbusbey merged commit eb54430 into quickfixgo:master Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug Behavior not matching expected

Projects

None yet

Milestone

v0.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@teloon @cbusbey