Allow stores to fall back to global settings for dynamic sessions #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ackleymi
force-pushed
the
support-dynamic-sessions-in-stores
branch
from
1504994 to
8e472f3
Compare
* Dynamic sessions are not added to the settings until after the session factory has created the sessions. In this scenario the filestore and sqlstore are unable to get the settings and fail to create the various message stores. Often these settings are set globally so we should try falling back before failing to create the message store.
ackleymi
force-pushed
the
support-dynamic-sessions-in-stores
branch
from
8e472f3 to
0dd076e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
factory has created the sessions. In this scenario the filestore and
sqlstore are unable to get the settings and fail to create the various
message stores. Often these settings are set globally so we should try
falling back before failing to create the message store.
Fixes #484