Skip to content

Align session's ticker with round second #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2022
Merged

Align session's ticker with round second #533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,6 +754,14 @@ func (s *session) run() {
}

})

// Without this sleep the ticker will be aligned at the millisecond which
// corresponds to the creation of the session. If the session creation
// happened at 07:00:00.678 and the session StartTime is 07:30:00, any new
// connection received between 07:30:00.000 and 07:30:00.677 will be
// rejected. Aligning the ticker with a round second fixes that.
time.Sleep(time.Until(time.Now().Truncate(time.Second).Add(time.Second)))

ticker := time.NewTicker(time.Second)

defer func() {
Expand Down