Fix some typos and re-generate code. #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 1, 2016 11:26
- doc.go has grammar correction and minor changes to assist users in reading. It is better to mention the name of the method in the usage documentation so users know the text they are reading belong to the example code above (or below) by their method name. - message_router.go has grammar correction. - _gen/generate-messages/main.go has a typo fix that propagated when code generation was ran.
- This is a follow-up of last commit where a typo was fixed in the _gen/generate-messages subprogram.
Contributor
|
Awesome, thanks for the contribution! 🍻 |
cbusbey
added a commit
that referenced
this pull request
Mar 1, 2016
Fix some typos and re-generate code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR includes only fix to typos, grammar improvements for the
quickfixpackage documentation, and code generation.The code generation was necessary because one of the typos was in
_gen/generate-messages/main.go.I've added all the info in the commit messages.
I've ran all the tests, including
make accept, all tests passed.I hope this is helpful to the project. I'm really impressed with it and would love to join you in contributing.