Disabling the lifo slot and variable shard load by default #5898
+56
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton-dd
force-pushed
the
paul.masurel/disable-lifo-slot-by-default
branch
4 times, most recently
from
c1b941a to
0c8c2b0
Compare
fulmicoton-dd
force-pushed
the
paul.masurel/disable-lifo-slot-by-default
branch
from
0c8c2b0 to
1c8e131
Compare
fulmicoton-dd
changed the title
PSeitz-dd
approved these changes
Sep 15, 2025
PSeitz-dd
reviewed
Sep 15, 2025
| fn enable_variable_shard_load() -> bool { | ||
| static IS_SHARD_LOAD_CP_ENABLED: OnceCell<bool> = OnceCell::new(); | ||
| *IS_SHARD_LOAD_CP_ENABLED.get_or_init(|| { | ||
| !quickwit_common::get_bool_from_env("QW_DISABLE_VARIABLE_SHARD_LOAD", false) |
Contributor
There was a problem hiding this comment.
In the future I think this pattern would be a bit simpler
QW_VARIABLE_SHARD_LOAD=true|enable
QW_VARIABLE_SHARD_LOAD=false|disable
Collaborator
Author
There was a problem hiding this comment.
I kind of disagree.
But I start thinking that the _DISABLE stuff was not a good idea. (The point was to suggest that the default was enabling of course, but it really sucks when we want to change the default)
fulmicoton-dd
force-pushed
the
paul.masurel/disable-lifo-slot-by-default
branch
from
1c8e131 to
701cee1
Compare
fulmicoton-dd
added a commit
that referenced
this pull request
Sep 23, 2025
Co-authored-by: Paul Masurel <paul@quickwit.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.